schema, config and eval scripts to make hidden eval dataset work #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiweiy
commented
Nov 10, 2023
| name="sam_sum", | ||
| scenario_spec=scenario_spec, | ||
| adapter_spec=adapter_spec, | ||
| metric_specs= get_summarization_metric_specs({"task": "sam_sum", "device": 'cpu'}) |
There was a problem hiding this comment.
@yifanmai Just want to run a sanity check — is using a summarization metric here fine?
|
@msaroufim now all the metrics should work correctly. If we ran example budgets 3k, we should have enough samples to make the summarization tasks stable |
msaroufim
approved these changes
Nov 11, 2023
msaroufim
reviewed
Nov 11, 2023
| scenario_spec=scenario_spec, | ||
| adapter_spec=adapter_spec, | ||
| metric_specs= get_summarization_metric_specs({"task": "sam_sum", "device": 'cpu'}) | ||
| + get_generative_harms_metric_specs(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@msaroufim, currently sam_sum is the only dataset doesn't work with helm-summerize and down stream eval scripts. Please have a look. Thanks.