Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/40 support waveshare75v1 #41

Merged
merged 7 commits into from
Sep 9, 2023

Conversation

JaquelineP
Copy link
Contributor

This PR relates to issue #40
I want to add support for the first version of waveshares 7.5inch I-ink display. I added a image to the showcase folder to show how it looks with the smaller resolution.
This is a draft pr. I will add some approvements to show more of the weather info on the left bottom. At the moment some icons are not shown (out of screen size).
@lmarzen Let me know what you think of the changes.

@lmarzen
Copy link
Owner

lmarzen commented Sep 6, 2023

Wow, that looks very good so far. I'm pleasantly surprised to see that the graph scaled nicely without any modifications.
Keep up the good work. Once you get the weather info on the left bottom and any other resizing that you deem necessary implemented, we will get the changes merged in. :)

@JaquelineP JaquelineP marked this pull request as ready for review September 9, 2023 16:03
@lmarzen lmarzen self-requested a review September 9, 2023 16:23
Copy link
Owner

@lmarzen lmarzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor fix, then I'll merge. Thanks for including an image too.

platformio/src/renderer.cpp Outdated Show resolved Hide resolved
platformio/src/renderer.cpp Outdated Show resolved Hide resolved
platformio/src/renderer.cpp Outdated Show resolved Hide resolved
JaquelineP and others added 3 commits September 9, 2023 19:44
Co-authored-by: Luke Marzen <98473324+lmarzen@users.noreply.github.com>
Co-authored-by: Luke Marzen <98473324+lmarzen@users.noreply.github.com>
Co-authored-by: Luke Marzen <98473324+lmarzen@users.noreply.github.com>
Copy link
Owner

@lmarzen lmarzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lmarzen lmarzen merged commit ebb36b3 into lmarzen:main Sep 9, 2023
3 checks passed
@lmarzen
Copy link
Owner

lmarzen commented Sep 9, 2023

Merged, thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants