Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylelint: Extend order config with new blocks and properties #180

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

literat
Copy link
Contributor

@literat literat commented Aug 5, 2024

Based on visionappscz/stylelint-config#60 and

The order config enforces a consistent order of content in your declaration blocks.:

  • Sass variables,
  • CSS custom properties,
  • Sass @extend,
  • single-line Sass @include,
  • declarations,
  • nested rules,
  • any other at-rules.

Based on visionappscz/stylelint-config#61

Add more properties to check their order

Properties added (sorted alphabetically):

  • accent-color
  • backdrop-filter
  • backface-visibility
  • background-blend-mode
  • border-spacing
  • box-decoration-break
  • caret-color
  • color-scheme, color-interpolation
  • column-fill, column-span
  • contain (including all long-hand variants)
  • container (including all long-hand variants)
  • counter-set
  • direction
  • empty-cells
  • font-size-adjust, font-variant-*, font-feature-settings, font-stretch, font-synthesis (including all long-hand variants), font-kerning, font-optical-sizing, font-palette
  • image-orientation, image-rendering
  • inset (including all long-hand variants),
  • justify-items
  • list-style-image
  • mask (including all long-hand variants), mask-border (including all long-hand variants), mask-type
  • mix-blend-mode
  • outline-*
  • overflow-anchor
  • overscroll-behavior (including all long-hand variants).
  • paint-order,
  • perspective, perspective-origin
  • place-content, place-items, place-self
  • quotes
  • scrollbar-*
  • table-layout
  • text-align-last, text-indent, text-decoration-skip-ink, text-underline-*, text-rendering, text-wrap (including all long-hand variants)
  • touch-action,
  • transform-box, transform-style, individual transforms: translate, rotate, scale,
  • transition-behavior
  • white-space-collapse
  • word-spacing

The key is roughly like this: all properties from MDN that are standard, widely supported, non-experimental, not specific for non-western languages, and not designed for paged media.

https://developer.mozilla.org/en-US/docs/Web/CSS

@literat literat requested a review from a team as a code owner August 5, 2024 13:26
@github-actions github-actions bot added the feature New feature or request label Aug 5, 2024
@literat
Copy link
Contributor Author

literat commented Aug 5, 2024

  • Update package readme accordingly

@literat literat changed the base branch from main to dependencies/stylelint-16.x August 5, 2024 13:27
@literat literat requested a review from adamkudrna August 5, 2024 13:27
@literat literat force-pushed the dependencies/stylelint-16.x branch from 228e047 to 8ffc8d6 Compare August 7, 2024 12:30
Base automatically changed from dependencies/stylelint-16.x to main August 7, 2024 12:36
@literat literat force-pushed the feat/stylelint-extend-order branch from 61b9406 to 6319062 Compare August 16, 2024 13:06
- `accent-color`
- `backdrop-filter`
- `backface-visibility`
- `background-blend-mode`
- `border-spacing`
- `box-decoration-break`
- `caret-color`
- `color-scheme`, `color-interpolation`
- `column-fill`, `column-span`
- `contain` (including all long-hand variants)
- `container` (including all long-hand variants)
- `counter-set`
- `direction`
- `empty-cells`
- `font-size-adjust`, `font-variant-*`, `font-feature-settings`, `font-stretch`,
  `font-synthesis` (including all long-hand variants), `font-kerning`, `font-optical-sizing`,
  `font-palette`
- `image-orientation`, `image-rendering`
- `inset` (including all long-hand variants),
- `justify-items`
- `list-style-image`
- `mask` (including all long-hand variants), `mask-border` (including all long-hand variants),
  `mask-type`
- `mix-blend-mode`
- `outline-*`
- `overflow-anchor`
- `overscroll-behavior` (including all long-hand variants).
- `paint-order`,
- `perspective`, `perspective-origin`
- `place-content`, `place-items`, `place-self`
- `quotes`
- `scrollbar-*`
- `table-layout`
- `text-align-last`, `text-indent`, `text-decoration-skip-ink`, `text-underline-*`,
  `text-rendering`, `text-wrap` (including all long-hand variants)
- `touch-action`,
- `transform-box`, `transform-style`, individual transforms: `translate`, `rotate`, `scale`,
- `transition-behavior`
- `white-space-collapse`
- `word-spacing`

The key is roughly like this: all properties from MDN that are standard, widely supported,
non-experimental, not specific for non-western languages, and not designed for paged media.

https://developer.mozilla.org/en-US/docs/Web/CSS
@literat literat force-pushed the feat/stylelint-extend-order branch 2 times, most recently from 899bd37 to 880078f Compare August 27, 2024 07:39
@literat literat requested a review from crishpeen August 27, 2024 07:49
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the config in Spirit and it works as expected 👍🏻.

packages/stylelint-config/README.md Outdated Show resolved Hide resolved
packages/stylelint-config/README.md Outdated Show resolved Hide resolved
@literat literat merged commit e26122c into main Sep 10, 2024
3 checks passed
@literat literat deleted the feat/stylelint-extend-order branch September 10, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants