Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eslint-config-base): Add support for Typescript in glob imports #181

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Feat(eslint-config-base): Add support for Typescript in glob imports #181

merged 1 commit into from
Aug 7, 2024

Conversation

literat
Copy link
Contributor

@literat literat commented Aug 5, 2024

  • `import/no-extraneous-dependencies now ignores also Typescript config files when importing from the devDependencies

@literat
Feat(eslint-config-base): Add support for Typescript in glob imports
5b394f4 
  * `import/no-extraneous-dependencies now ignores also Typescript config files when importing
     from the devDependencies
@literat literat requested a review from a team as a code owner August 5, 2024 14:43
@github-actions github-actions bot added the feature New feature or request label Aug 5, 2024
adamkudrna
adamkudrna reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we will be able to get rid of this? 👍🏻

/* eslint-disable import/no-extraneous-dependencies */

@literat
Copy link
Contributor Author

literat commented Aug 6, 2024

So we will be able to get rid of this? 👍🏻

/* eslint-disable import/no-extraneous-dependencies */

Yes, I hope so :-)

@literat literat merged commit 212a228 into main Aug 7, 2024
4 checks passed
@literat literat deleted the feat/eslint-glob-import-typescript branch August 7, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna left review comments

Assignees

@literat literat

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@literat @adamkudrna