adds CardaNostra extension #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lol, i checked out the extension and it seemed like fake :D |
|
what exactly is "fake" about it? |
|
sorry, i guess the default branch |
|
Its a great tool that should exist. We can not merge now however as it has its own dependencies (https://github.com/ponthief/cardanostra/blob/95098b8c73686f8e5bb2a941b2bb8dc11634b9e0/pyproject.toml#L11) and is using monstr which is impossible to vet. |
|
How is switching over to nostrclient? |
|
Let's close this PR for now and open a new one when CardaNostra releases a version that moved to using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.