trying to correctly configure position independent code

lobis · Dec 6, 2023 · 98bf14c · 98bf14c
1 parent bbb5373
commit 98bf14c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/.github/workflows/build-test-static.yaml b/.github/workflows/build-test-static.yaml
@@ -54,7 +54,7 @@ jobs:
           git -C xerces-source checkout tags/v3.2.4
           mkdir -p ${{ github.workspace }}/xerces-source/build
           cd ${{ github.workspace }}/xerces-source/build
-          cmake .. -DCMAKE_INSTALL_PREFIX=${{ github.workspace }}/xerces -DCMAKE_CXX_STANDARD=20 -DBUILD_SHARED_LIBS=OFF -DCMAKE_BUILD_TYPE=Release -Dnetwork-accessor=socket -Dtranscoder=iconv -DCMAKE_CXX_FLAGS=-fPIC
+          cmake .. -DCMAKE_INSTALL_PREFIX=${{ github.workspace }}/xerces -DCMAKE_CXX_STANDARD=20 -DBUILD_SHARED_LIBS=OFF -DCMAKE_BUILD_TYPE=Release -Dnetwork-accessor=socket -Dtranscoder=iconv -DCMAKE_CXX_FLAGS=-fPIC -DCMAKE_C_FLAGS=-fPIC
           make install -j$(nproc)
 
       - name: Cache Geant4 Installation
@@ -70,7 +70,7 @@ jobs:
           git clone https://github.com/Geant4/geant4.git ${{ github.workspace }}/geant4-source --depth 1 --branch v${{ matrix.geant4-version }}
           mkdir -p ${{ github.workspace }}/geant4-source/build
           cd ${{ github.workspace }}/geant4-source/build
-          cmake .. -DCMAKE_INSTALL_PREFIX=${{ github.workspace }}/geant4 -DCMAKE_CXX_STANDARD=20 -DCMAKE_BUILD_TYPE=Release -DGEANT4_USE_GDML=ON -DGEANT4_INSTALL_EXAMPLES=OFF -DGEANT4_INSTALL_DATA=OFF -DGEANT4_BUILD_TLS_MODEL=global-dynamic -DCMAKE_CXX_FLAGS=-fPIC -DGEANT4_USE_SYSTEM_EXPAT=OFF -DBUILD_STATIC_LIBS=ON -DBUILD_SHARED_LIBS=OFF -DXERCESC_ROOT_DIR=${{ github.workspace }}/xerces
+          cmake .. -DCMAKE_INSTALL_PREFIX=${{ github.workspace }}/geant4 -DXERCESC_ROOT_DIR=${{ github.workspace }}/xerces -DCMAKE_CXX_STANDARD=20 -DCMAKE_BUILD_TYPE=Release -DGEANT4_USE_GDML=ON -DGEANT4_INSTALL_EXAMPLES=OFF -DGEANT4_INSTALL_DATA=OFF -DGEANT4_BUILD_TLS_MODEL=global-dynamic -DCMAKE_CXX_FLAGS=-fPIC -DCMAKE_C_FLAGS=-fPIC -DGEANT4_USE_SYSTEM_EXPAT=OFF -DBUILD_STATIC_LIBS=ON -DBUILD_SHARED_LIBS=OFF
           make install -j$(nproc)
 
   install-geant4-datasets:

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -88,7 +88,6 @@ endif ()
 set_target_properties(
     ${PYTHON_MODULE_NAME}
     PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/${PROJECT_NAME}
-               COMPILE_FLAGS "-fPIC"
                CXX_VISIBILITY_PRESET "hidden"
                CUDA_VISIBILITY_PRESET "hidden")