Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ramp down parameter not working #49

Open
jherkenhoff opened this issue Oct 30, 2023 · 1 comment
Open

Ramp down parameter not working #49

jherkenhoff opened this issue Oct 30, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jherkenhoff
Copy link
Collaborator

When trying to set the ramp down speed of a CAEN R803x channel, it responds with a command error.
From the manual I see that the command should be RDWN, while in the sourc it is RDW:

"RDW": "VAL:XXX Set RAMP DOWN value",

Attached is a screenshot from the R803x manual:
Screenshot from 2023-10-30 14-23-20

Is the RDW command in the source code a typo, or are there actually devices that use this command? If so, could I maybe simply add the RDWN command to the list?

@jherkenhoff jherkenhoff added bug Something isn't working good first issue Good for newcomers labels Oct 30, 2023
@lobis
Copy link
Owner

lobis commented Oct 30, 2023

From the R14xxET etc. manual (UM3372):

Screenshot 2023-10-30 at 09 57 42

I'm afraid there is some inconsistency between the commands for different devices... Or perhaps something that we are missing. At a glance looks like my PS has more options related to ramp up / down, perhaps that is the reason for the shorter name? If this issue is widespread probably it would be best to have separate classes for each family of power supplies, but it would involve some work which I cannot do at this time. Perhaps it can be enough to do some kind of try / except logic to figure out the right command for a given device (atleast for now).

In summary: we cannot remove the RDW command, but I'm sure it possible to add the RDWN command somehow, feel free to open a PR with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants