Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes polyfills and es6 code #379

Closed
wants to merge 1 commit into from

Conversation

markconroy
Copy link
Member

Closes #378

What does this change?

Removes polyfill files and ES6 specific files, so we can just use modern JS instead.

How to test

Create some alert banners, make sure they still work


Thanks to Big Blue Door for sponsoring my time to work on this.

@andybroomfield andybroomfield changed the base branch from 1.x to 1.8.x September 23, 2024 21:41
@andybroomfield
Copy link
Contributor

Updated base so this goes into 1.8.x.

The main js looks good (swapping var for const).
I'll let @Adnan-cds look at the full screen js as I think hes more familliar with it.

Copy link
Contributor

@Adnan-cds Adnan-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. No errors or warnings in browser's Javascript console. Code changes also look good. Coding standards failures are unrelated. Thank you :)

@andybroomfield
Copy link
Contributor

The conflicts come from this branch originating from 1.x, but the target is 1.8.x since the refactor is changing the javascript. I'd rather we target into 1.8.x and push to get that released as it also removes the js-cookie dependancy. It might be easier to open a new PR sourcing from 1.8.x so it applies to refactored js. Looks like it's mostly convertng var to const?

@markconroy
Copy link
Member Author

New PR created from 1.8.x #381

@markconroy markconroy closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we remove the polyfills and es6.js files from alert banner?
3 participants