Check if emergency publisher role exists before changing permissions #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed duplicated declarations and added missing ' on line 245
|
@andybroomfield Found and fixed issues: 62f625b |
AWearring
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Tested locally and this resolves the error we were getting:
> [notice] Update started: localgov_alert_banner_update_10002
> [error] Call to a member function revokePermission() on null
> [error] Update failed: localgov_alert_banner_update_10002
[error] Update aborted by: localgov_alert_banner_update_10002
[error] Finished performing updates.
|
Thanks @AWearring and also verified this applies the permissions to those with the emergency publisher role. |
Merged
andybroomfield
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #388
What does this change?
Fix bug reported in #386
How to test
Install 1.7.10 and then delete the emergency publisher role.
You should still be able to run the latest DB update.
How can we measure success?
Councils can install the update if they have removed the emergency publisher role.
Have we considered potential risks?
Should be minimal, role might have changed permissions that need it.
Images
n/a
Accessibility
n/a