Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fail on alert banner as target to 1.8.x can't be resolved to a set of dependencies #3

Closed
andybroomfield opened this issue Jul 10, 2024 · 2 comments

Comments

@andybroomfield
Copy link

See https://github.com/localgovdrupal/localgov_alert_banner/actions/runs/9872131554/job/27261593508?pr=346

Your requirements could not be resolved to an installable set of packages.

Problem 1
Error: Your requirements could not be resolved to an installable set of packages.

Problem 1
- localgovdrupal/localgov is locked to version 3.x-dev and an update of this package was not requested.
- localgovdrupal/localgov 3.x-dev requires localgovdrupal/localgov_alert_banner ^1.2.0 -> found localgovdrupal/localgov_alert_banner[1.2.0, ..., 1.x-dev] but it conflicts with your root composer.json require (dev-fix/345-add-banner-type-accessible-name as 1).

- localgovdrupal/localgov is locked to version 3.x-dev and an update of this package was not requested.
- localgovdrupal/localgov 3.x-dev requires localgovdrupal/localgov_alert_banner ^1.2.0 -> found localgovdrupal/localgov_alert_banner[1.2.0, ..., 1.x-dev] but it conflicts with your root composer.json require (dev-fix/345-add-banner-type-accessible-name as 1).

I think it's getting confused with the 1.8.x.

@millnut
Copy link
Member

millnut commented Jul 11, 2024

Yep I think it's related to the previous steps on how it works out which env vars to set.

Working

env:
  GIT_BASE: 1.x
  GIT_BRANCH: 1-8-refactor
  HEAD_USER: localgovdrupal
  COMPOSER_REF: dev-1-8-refactor
  LATEST_RELEASE: 1.7.8
  COMPOSER_PROCESS_TIMEOUT: 0
  COMPOSER_NO_INTERACTION: 1
  COMPOSER_NO_AUDIT: 1
  env:
    GIT_BASE: 1.8.x
    GIT_BRANCH: 1.8.x
    HEAD_USER: localgovdrupal
    COMPOSER_REF: 1.8.x-dev
    LATEST_RELEASE: 1
    COMPOSER_PROCESS_TIMEOUT: 0
    COMPOSER_NO_INTERACTION: 1
    COMPOSER_NO_AUDIT: 1

Not working

env:
  GIT_BASE: 1-8-refactor
  GIT_BRANCH: 1-8-refactor
  HEAD_USER: localgovdrupal
  COMPOSER_REF: dev-1-8-refactor
  LATEST_RELEASE: 1
  COMPOSER_PROCESS_TIMEOUT: 0
  COMPOSER_NO_INTERACTION: 1
  COMPOSER_NO_AUDIT: 1
  env:
    GIT_BASE: 1.8.x
    GIT_BRANCH: fix/345-add-banner-type-accessible-name
    HEAD_USER: localgovdrupal
    COMPOSER_REF: dev-fix/345-add-banner-type-accessible-name
    LATEST_RELEASE: 1
    COMPOSER_PROCESS_TIMEOUT: 0
    COMPOSER_NO_INTERACTION: 1
    COMPOSER_NO_AUDIT: 1

I believe it's due to GIT_BASE and LATEST_RELEASE which is used in composer which is causing the issues, I'll do some debugging when I have some time on how it gets the latest release values.

@millnut
Copy link
Member

millnut commented Aug 6, 2024

Closing as this has been fixed by #4

@millnut millnut closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants