-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print logs of ephemeral instance after executing preview-cmd #38
Conversation
The ephemeral instance for the application preview has been shut down |
ff9eaad
to
2899362
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! 👍 💯 🥇
As we've discussed on a different channel this will be a good addition as a separate sub-action to be usable in other actions or on it's own modularly. -> TBD
Additionally this log fetching should be done at least on failures but could be beneficial every time.
Background
With @remotesynth and @HarshCasper working on the blog post for ephemeral instances and application previews, they have identified the need for getting logs of LocalStack, in case the deployment of their application (= preview-cmd) failed.
Debugging issues with a deployment on LocalStack without logs is basically impossible.
Solution
This PR invokes the new endpoint to fetch logs of ephemeral instances after the preview-cmd is finished, and prints them.