Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print logs of ephemeral instance after executing preview-cmd #38

Merged
merged 12 commits into from
Aug 20, 2024

Conversation

lukqw
Copy link
Member

@lukqw lukqw commented Aug 9, 2024

Background

With @remotesynth and @HarshCasper working on the blog post for ephemeral instances and application previews, they have identified the need for getting logs of LocalStack, in case the deployment of their application (= preview-cmd) failed.
Debugging issues with a deployment on LocalStack without logs is basically impossible.

Solution

This PR invokes the new endpoint to fetch logs of ephemeral instances after the preview-cmd is finished, and prints them.

Copy link

github-actions bot commented Aug 9, 2024

The ephemeral instance for the application preview has been shut down

@lukqw lukqw force-pushed the print-eph-inst-logs branch from ff9eaad to 2899362 Compare August 14, 2024 14:34
@lukqw lukqw marked this pull request as ready for review August 19, 2024 15:36
@lukqw lukqw requested a review from lakkeger August 19, 2024 15:38
Copy link
Contributor

@lakkeger lakkeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! 👍 💯 🥇

As we've discussed on a different channel this will be a good addition as a separate sub-action to be usable in other actions or on it's own modularly. -> TBD

Additionally this log fetching should be done at least on failures but could be beneficial every time.

@lukqw lukqw merged commit 84a2a9c into main Aug 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants