Don't wrap modules #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronos30
approved these changes
Jan 21, 2025
Comment on lines
+168
to
+172
| # TODO: remove, this is to debug | ||
| get_cmake_property(_variableNames VARIABLES) | ||
| foreach (_variableName ${_variableNames}) | ||
| message(STATUS "${_variableName}=${${_variableName}}") | ||
| endforeach() |
There was a problem hiding this comment.
Would it be worth leaving and comment it out, so we can use it to debug later?
jprestwo
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
SCRIPTSoption to theament_python_install_packagemacro and only wraps those scripts.