-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Fixed) IR Additions #543
(Fixed) IR Additions #543
Conversation
Remote has a CD/CDR switch, so there are two remote files.
Remote has two modes, so two separate files
Remote files are for Deck A and Deck B
Remotes have a mode switch to toggle between four different cameras. I have captured each one as it's own .ir file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐛 Linter Result
DVD_Players/GPX/GPX_D2816.ir
[2 issues]
# Line 278:
- name: Prev
^^^^
@@ ambiguous name 'Prev' @@
# Line 284:
- name: Next
^^^^
@@ ambiguous name 'Next' @@
I fixed the fix I didn't fix right
I can't do a good job explaining, except I think I tried to fix it from the linter, decided against it, and un-fixed the wrong thing. Does it look OK now? |
(And thank you for helping me. I'm not used to using a proper github workflow with others) |
Yes, looks good now 👍 |
Thank you very much! |
The only thing I would like to ignore with the linter, if possible, is for the GPX_D2816.ir file. The remote actually has printed "Prev" and "Next." I can change them, if you'd prefer, but I thought I'd explain first.
Otherwise, I think everything else is fixed.