Fix invalid feed error and update to 5.0 event api #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exception, in this case now this error is log and the plugin continues to operate. Also intoduced some simple test cases for when the rss is perfect, when is valid but empty and for when is invalid.
|
@guyboertje your thoughts here are welcome. |
|
@purbon - looks good so far. Please make one of the failure fixtures an atom feed. |
|
@guyboertje can do that, will look for examples. |
|
@guyboertje added atom test as requested, also helped fixing a few issues 👍 , let me know what do you think. |
|
LGTM |
added 4 commits
June 14, 2016 16:45
…ld is not supose to be in all atom feeds as of the specs added atom tests
purbon
changed the title
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jun 14, 2016
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jun 14, 2016
…ld is not supose to be in all atom feeds as of the specs added atom tests Fixes #18
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jun 14, 2016
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jun 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
include code to be using the new logstash-core api, backport will be necessary.
fixes #1
relates to elastic/logstash#5309