Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] set servicegraph flush interval #562

Merged
merged 7 commits into from
Nov 20, 2024

Conversation

yotamloe
Copy link
Contributor

@yotamloe yotamloe commented Nov 20, 2024

Description

4.3.0

  • Set metrics_flush_interval -> 60s
  • Add test for servicegraph metrics

What type of PR is this?

(check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build / CI
  • ⏩ Revert

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help from somebody

@yotamloe yotamloe requested review from ralongit and 8naama November 20, 2024 09:45
Copy link
Contributor

@8naama 8naama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! πŸ’ͺ🏼

I think the issue with the service graph metrics not being generated, may be that the traces generator is not creating spans with span.kind of type client and service

@yotamloe
Copy link
Contributor Author

@8naama Yes I figured out that to create servicegraph metrics we need multiple services sending requests to each other. load generator generates traces from one service. I added otel demo to test runs for a better use case

Copy link
Contributor

@ralongit ralongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work πŸ”₯

@yotamloe yotamloe merged commit 51582a6 into master Nov 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants