Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getEmbedDirection() #4

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Remove getEmbedDirection() #4

merged 1 commit into from
Jul 31, 2023
+12 −11

Conversation

nmtigor
Copy link
Contributor

@nmtigor nmtigor commented Jul 23, 2023

By the spec, "all the level runs in an isolating run sequence have the same embedding level". So getEmbedDirection() should not be necessary.

Observed that embed levels of some characters could be increased in l1, l2, L1, but there is already no use of getEmbedDirection().

npm test passed.

lojjic
lojjic requested changes Jul 31, 2023
View reviewed changes
Copy link
Owner

@lojjic lojjic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thanks! Would you mind adding a brief comment where you capture the embedDirection that explains why this optimization is safe, for future reference?

@lojjic lojjic merged commit 81f1d72 into lojjic:main Jul 31, 2023
1 check passed
@lojjic
Copy link
Owner

lojjic commented Jul 31, 2023

Thanks for all the PRs! I've published v 1.0.3 to npm.

@nmtigor nmtigor deleted the b-remove_getEmbedDirection branch July 31, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lojjic lojjic lojjic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmtigor @lojjic