Use built-in FindSDL2

.github/workflows/build.yaml

@@ -216,7 +216,6 @@ jobs:
       - name: Install build tools
         run: |
           brew update
-          brew uninstall --ignore-dependencies python
           brew install \
             cmake \
             ninja \
@@ -274,7 +273,6 @@ jobs:
       - name: Debug
         if: failure()
         run: |
-          cat /Users/runner/work/freeciv21/freeciv21/vcpkg/buildtrees/fontconfig/x64-osx-dbg/meson-logs/meson-log.txt
           cat CMakeCache.txt
           echo ${{steps.split.outputs.fragment}}
       - name: Upload package

client/CMakeLists.txt

@@ -158,7 +158,6 @@ target_link_libraries(freeciv21-client PRIVATE tolua)
 
 target_link_libraries(freeciv21-client PRIVATE Qt5::Widgets)
 target_link_libraries(freeciv21-client PRIVATE Qt5::Svg)
-target_link_libraries(freeciv21-client PRIVATE ${SDL2_MIXER_LIBRARIES} ${SDL2_LIBRARY})
 
 if(NOT EMSCRIPTEN)
   target_sources(freeciv21-client PRIVATE servers.cpp)
@@ -168,13 +167,14 @@ if (AUDIO_SDL)
   target_sources(freeciv21-client PRIVATE audio/audio_sdl.cpp)
   if (NOT EMSCRIPTEN)
     # SDL comes with the -s option on emscripten
-    target_include_directories(freeciv21-client PRIVATE ${SDL2_INCLUDE_DIR})
+    target_link_libraries(freeciv21-client PRIVATE SDL2::SDL2)
+    target_link_libraries(freeciv21-client PRIVATE ${SDL2_MIXER_LIBRARIES})
     target_include_directories(freeciv21-client PRIVATE ${SDL2_MIXER_INCLUDE_DIR})
   endif()
 endif()
 
 if(APPLE)
-  target_link_libraries(freeciv21-client PRIVATE "-framework AudioUnit" "-framework CoreAudio" "-framework ForceFeedback" "-framework AudioToolbox")
+  # target_link_libraries(freeciv21-client PRIVATE "-framework AudioUnit" "-framework CoreAudio" "-framework ForceFeedback" "-framework AudioToolbox")
   qt5_import_plugins(freeciv21-client INCLUDE Qt5::QCocoaIntegrationPlugin Qt5::QSvgPlugin)
 endif()