Fix penalizing buy-then-change-production #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a player buys a unit that cannot be built then switches to building something else, penalize half of the shields that were bought. This changes the previous overjealous behaviour where half the total amount of shields would be lost. Closes longturn#1915.
|
Does this change the network protocol? I'll do a more careful review tomorrow. |
|
Yes, but in a backward compatible way (though I realize I didn't test... connecting to a running game should be enough). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a player buys a unit that cannot be built then switches to building something else, penalize half of the shields that were bought. This changes the previous overjealous behaviour where half the total amount of shields would be lost.
Closes #1915.
Testing done
Uniqueflag to warriors inclassicand started a game. Bought a couple Warriors before I had any, then changed production to Settlers. Half of the shields I had bought disappeared as expected.