Improve texts in the research view #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With tech upkeep enabled, the text was looking like: Progress: %1 turn/advance (%1 bulb/turn)Bulbs produced per turn: %1 Add a newline after the closing parenthesis.
The price of a tech can change due to tech leak. In this case it isn't researched immediately and the player may see 123/100 bulbs. Account for this when calculating how many turns are left to discover the tech.
The research view has a text with the number of bulbs and turns needed to achieve the current tech goal. This text had issues in multiple situations: * When no goal was set, it was showing "(0 steps - 0 bulbs - never)"; * It was never taking tech leak into account. Solve these issues by considering the current research as the implicit goal if none is set, and taking the actual cost of the current research into account. The label still does not take tech leak into account for the following techs, even if the player knows that the cost will be lower (e.g. through diplomacy).
|
Is there a savegame or something I can use to test this? |
|
Unfortunately not, I was testing by observing Blauwal in LT79. |
jwrober
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the following texts in the research view header following a comment by Blauwal on Discord:
Some small code improvements here and there as well.
I think the risks of backporting this outweigh the benefits.