Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure icon png available for win32 #2012

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Ensure icon png available for win32 #2012

merged 2 commits into from
Jul 26, 2023

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Jul 25, 2023

Found a regression from #2004. Fixing here. No related issue.

@jwrober jwrober requested a review from lmoureaux July 25, 2023 21:43
lmoureaux
lmoureaux approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does Windows need a jpg in the first place?

@jwrober
Copy link
Collaborator Author

jwrober commented Jul 26, 2023

For some reason the client uses misc/icons.spec to get the main icon on the program. I found it on my main Linux side, but was playing around on my Msys2 machine and noticed the same. If the icon file is missing, the client displays as a red square.

Looks like I didn't do something right. Msys2 install not working. Will push a fix.

@jwrober jwrober changed the title Ensure icon jpg available for win32 Ensure icon png available for win32 Jul 26, 2023
@jwrober jwrober merged commit 38dfd45 into longturn:master Jul 26, 2023
16 checks passed
@jwrober jwrober deleted the windows-icon-fix branch January 2, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoureaux lmoureaux lmoureaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwrober @lmoureaux