Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make units on cities visible when city drawing is disabled #2022

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

rsubtil
Copy link
Contributor

@rsubtil rsubtil commented Aug 22, 2023

Suggested on Discord. This will draw units stationed in cities when drawing cities is disabled in the settings.

Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great addition, thanks!
It seems you inadvertently changed the newlines in the Windows batch script to start the client, could you revert to the original?

@rsubtil
Copy link
Contributor Author

rsubtil commented Aug 22, 2023

Oops, yeah sorry, didn't notice it! 😅

@lmoureaux lmoureaux enabled auto-merge (rebase) August 22, 2023 20:11
@lmoureaux
Copy link
Contributor

Feel free to submit a PR if you want to add yourself to AUTHORS, we try to document copyright holders there

@rsubtil
Copy link
Contributor Author

rsubtil commented Aug 22, 2023

Thanks! I might actually make some more significant contributions due to my existing work, so in the future I can do that.

@lmoureaux lmoureaux mentioned this pull request Aug 22, 2023
@lmoureaux lmoureaux merged commit 42dffcd into longturn:master Aug 22, 2023
19 of 20 checks passed
@rsubtil rsubtil deleted the contrib branch August 22, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants