Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcdb.rst update #2036

Merged
merged 4 commits into from
Sep 27, 2023
Merged

fcdb.rst update #2036

merged 4 commits into from
Sep 27, 2023

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Sep 20, 2023

Update the fcdb.rst file based on recent Discord conversation where the instructions were not clear for a new user. Also update the CPackConfig.cmake file to specifically ask for lua5.3 package.

Recommend we backport the commit to CPackConfig.cmake to stable branch.

Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern is the introduction of a new dependency to a Lua interpreter, which is not needed for anyone.

docs/Manuals/Server/fcdb.rst Outdated Show resolved Hide resolved
cmake/CPackConfig.cmake Outdated Show resolved Hide resolved
docs/Manuals/Server/fcdb.rst Outdated Show resolved Hide resolved
docs/Manuals/Server/fcdb.rst Show resolved Hide resolved
@lmoureaux lmoureaux enabled auto-merge (rebase) September 27, 2023 21:26
@lmoureaux lmoureaux merged commit c6e48f2 into longturn:master Sep 27, 2023
18 checks passed
@jwrober jwrober deleted the docs/fcdb-update branch January 2, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants