Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong numbers of turns displayed after buying #2090

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

lmoureaux
Copy link
Contributor

The client's accounting of the shield stock didn't always take the bought shields into account.

Closes #1848.

Backport candidate.

The client's accounting of the shield stock didn't always take the bought
shields into account.

Closes longturn#1848.
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Backport approved

@lmoureaux lmoureaux merged commit cb9df28 into longturn:master Dec 27, 2023
19 checks passed
@lmoureaux lmoureaux deleted the bugfix/bought-shields branch December 27, 2023 16:35
@lmoureaux
Copy link
Contributor Author

Cannot backport because a protocol change is needed for the client to have enough information (would need to backport #1996 and #2018 as well)

@jwrober
Copy link
Collaborator

jwrober commented Dec 27, 2023

Ok then let's not do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rush buying a unit shows complete in 2 turns
2 participants