Commits on May 21, 2024

1. Sort unit lists shown to the user …

   This patch makes the user interface look more consistent by sorting
   units in two contexts:
   
   * In the city dialog
   * In the unit picker
   
   The sorting logic is an improved version of code formerly used to sort
   units in the city dialog (but that had been lost for some reasion). It
   tries to produce a sort order that looks natural and is stable in time.
   To do so:
   
   * Loaded units are always sorted right after their transport, so one can
     tell in which transport they are loaded;
   * The best defensive units go to the beginning of the list. These tend
     to stay in cities and not move around too much;
   * Tie breaker by unit type and nationality ensure similar units are
     grouped together;
   * Finally, the unit id is used as a last resort.
   
   I tested this logic in a few contexts and it seems to achieve its goal.
   With respect to the previous sorting function, I removed an order based
   on unit activities (fortified, fortifying, sentried) because it felt
   wrong to have a unit move in the list just because I changed its
   activity.
   
   Closes longturn#1836.
   See longturn#1838.

   

   lmoureaux committed May 21, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 83bde24
   • Browse repository at this point

   Copy the full SHA

   83bde24 View commit details

   Browse the repository at this point in the history