Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governor fixes #2301

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Governor fixes #2301

merged 4 commits into from
Jul 1, 2024

Commits on Jun 30, 2024

  1. Flush attributes as soon as they are set 

    This is inefficient in terms of network traffic, but it means governors
are saved immediately, which is usually what the user wants.
    @lmoureaux
    lmoureaux committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    9254ee0 View commit details
    Browse the repository at this point in the history

  2. Don't set governors parameters when getting them 

    Every time the governor parameter were fetched, they would be
deserialized from the attribute, then serialized again to the same
values. Stop doing that.
    @lmoureaux
    lmoureaux committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    cccb608 View commit details
    Browse the repository at this point in the history

  3. Governor widget: send updates after 100ms 

    This prevents sending multiple updates when every slider gets modified.
    @lmoureaux
    lmoureaux committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    e626324 View commit details
    Browse the repository at this point in the history

  4. Remove useless function handle_city() in governor.cpp

    @lmoureaux
    lmoureaux committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    ae12647 View commit details
    Browse the repository at this point in the history