Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix research refresh button #2384

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Sep 10, 2024

Closes #1753

Marking as draft for now. Need an event to test it.

@lmoureaux
Copy link
Contributor

I doubt this will work, handle_player_tech_goal in server/techtools.cpp doesn't seem to set the current tech.

Moreover, this would wipe out any tech goal previously set by the user.

@jwrober
Copy link
Collaborator Author

jwrober commented Sep 10, 2024

Ouch. Well glad I pushed this draft before I blew out a turn giving a test. Ideas on what to try next?

@lmoureaux
Copy link
Contributor

See my comment on the issue. Try removing this line... but you need to set up a local test :)

@jwrober
Copy link
Collaborator Author

jwrober commented Sep 10, 2024

That has been my biggest problem. I have not been able to get a local save with the "problem" in it to test locally.

@lmoureaux
Copy link
Contributor

save.zip

@jwrober jwrober changed the title Add dsend_packet_player_tech_goal() to research refresh button Fix research refresh button Sep 11, 2024
@jwrober jwrober marked this pull request as ready for review September 11, 2024 17:55
@jwrober
Copy link
Collaborator Author

jwrober commented Sep 11, 2024

I never thought about hacking a save file. Nice. The suggestion works great.

@lmoureaux lmoureaux merged commit 7a1644c into longturn:master Sep 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to forcibly research a tech that is instantly researchable after TC due to tech leak
2 participants