Rework how the units view is updated #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the logic to update the units table into a dedicated method and adapts the code in a way, that the content of the units table is not regenerated on update, but the already existing table contents are updated as needed. This allows the table to keep its selection on update.
If the units view is reopened after it has already been opened once, call the newly created method to update the units table. Fixes longturn#2399.
|
I will keep this as a draft, while I do some additional testing. Feel free to comment and test. |
blabber
changed the title
|
Something tells me that this is an issue from the get-go when I originally created the new view. I'll check it out on my local. |
The update of the buttons in the units view was triggered by a selection change in the units table. As the update of the units table no longer recreates its contents from scratch and the table therefore no longer loses its seletion, the buttons have to be updated explicitely after the update.
|
I fixed the one issue I noticed while testing locally, this should be ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic to update the units table has been moved into a dedicated method and has been adapted in a way, that the content of the units table is not regenerated on update. Instead the already existing table contents are updated as needed. This allows the table to keep its selection on update.
If the units view is reopened after it has already been opened once, this newly created method is called to update the units table.
Fixes #2399.