Remove OAuth token from query params in API requests #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking to merge this again... Reverted because we were cutting a new release before this was tested. |
…enFromQueryParams
goomrw
force-pushed
the
revert-176-revert-171-shivane/removeOAuthTokenFromQueryParams
branch
from
b299a4c
to
d91f423
Compare
Looker accesses this private API via reflection, so we need to keep it. This doesn't revert the fundamental point of this PR, which is to stop setting the OAuth token as a BigQuery API parameter.
goomrw
deleted the
revert-176-revert-171-shivane/removeOAuthTokenFromQueryParams
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR was reverted because we did not do a full integration test between Helltool and BigQuery OAuth with these changes, and we wanted to unblock other PRs. Now, I'm revisiting this issue