feat: Adds CI implementation #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremytchang
requested changes
Feb 1, 2024
jeremytchang
requested changes
Feb 1, 2024
There was a problem hiding this comment.
Copying the requirements here:
Based off this example PR:
- Copy the .github/workflows directory with its 2 yaml files.
- For README, outside of initial unique info per viz, the rest should be exact copy.
- Update webpack config to output the js bundle to
dist\bundle.js. This must result fromyarn buildcall to ensure release workflow works. Looks like some of the webpack configs are inconsistent, so we’ll need to be careful here and ensure locally the output is correct. - Remove any minified bundle js files.
- Update gitignore to ignore dist directory
- Make sure the master branch is called
masterfor release and ci workflow to work.
yesudeep
approved these changes
Feb 8, 2024
jeremytchang
approved these changes
Mar 18, 2024
|
Hey @andres-rubio-go could we please address the build problem and get this PR merged? |
Merged
yesudeep
pushed a commit
that referenced
this pull request
Jul 4, 2024
Hi! Patching from [this PR ](#18 I can fix the ci-workflow from Github as logs are no longer available in that one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.