Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix build #19

Merged
merged 1 commit into from
Apr 3, 2024
Merged

chore: Fix build #19

merged 1 commit into from
Apr 3, 2024

Conversation

jeremytchang
Copy link

This is the error we're getting in build:

ERROR in ./node_modules/vega-label/build/vega-label.module.js 557:33
Module parse failed: Unexpected token (557:33)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|       return false;
|     }
>     let textWidth = d.textWidth ?? 0,
|       dx,
|       dy,
 @ ./node_modules/vega/build/vega.module.js 11:0-36 33:48-53
 @ ./node_modules/vega-embed/build/vega-embed.module.js
 @ ./src/histogram.js

It looks suspiciously like this one: vega/vega#3683
I added babel-loader babel core and preset-env and updated the webpack config to use babel with the hopefully the right preset and plugin, but it still doesn't fix it.

@jeremytchang jeremytchang requested a review from a team as a code owner February 1, 2024 22:04
@jeremytchang jeremytchang changed the title wip chore: Fix build Feb 1, 2024
@yesudeep
Copy link

@andres-rubio-go can you please take a look at this PR, test, update, and merge the fix?

@andres-rubio-go andres-rubio-go merged commit 41662c7 into master Apr 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants