Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] angular frontend with openapi-generator sdk #577

Closed
wants to merge 6 commits into from

Conversation

derdeka
Copy link
Contributor

@derdeka derdeka commented Feb 27, 2020

This spike aims to implement an angular frontend with the help of OpenApi Generator.

Early feedback and contributors who like to join the spike welcomed.

Related to: loopbackio/loopback-next#4610

Signed-off-by: derdeka <derdeka@blackslash.de>
Signed-off-by: derdeka <derdeka@blackslash.de>
Signed-off-by: derdeka <derdeka@blackslash.de>
Signed-off-by: derdeka <derdeka@blackslash.de>
Signed-off-by: derdeka <derdeka@blackslash.de>
Signed-off-by: derdeka <derdeka@blackslash.de>
*/


export interface InlineResponse2001 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To resolve the responses to meaningful model names you need to ensure that the response schemas have a title property. The following would resolve InlineResponse2001 to AuthResponse:

{
  type: 'object',
  title: 'AuthResponse',
  properties: {
    token: {
      type: 'string',
    },
  },
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you've done it further down! 👍

Copy link
Contributor

@dougal83 dougal83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Generally I'd discourage a folder structure placing the API (services) in shared as it implies optional. Perhaps use a structure that would place services in a folder named something like core? In this pattern shared would be for optional things like pipes, validators etc.

Other than the above personal preference it's a good start! 👍 Thank you for getting the ball rolling.

@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been marked stale because it has not seen activity within two months. It will be closed within 14 days of being stale unless there is new activity.

@stale stale bot added the stale label Dec 25, 2020
@stale
Copy link

stale bot commented Jul 9, 2021

This pull request has been closed due to continued inactivity. If you are interested in finishing the proposed changes, then feel free to re-open this pull request or open a new one.

@stale stale bot closed this Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants