Jamesmoore/arch 224 silo support device groups #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
…g hash checks Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
Signed-off-by: Jimmy Moore <jamesmoore@loopholelabs.io>
|
The only real missing piece here now is how Silo schema is given in the case of a start, or tweaked in the case of a migration. This means for example, we'd want to add s3 sync to the memory and disk devices. The code includes tweak() functions that take in a Silo schema and can modify or return a new one for use. This is all that's left. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for Silo/Drafter API refactor