Skip to content

Commit

Permalink
Merge pull request #6 from seeba8/master
Browse files Browse the repository at this point in the history
Fixes condition to query for data on getPageInfo
  • Loading branch information
lostsnow authored Apr 24, 2017
2 parents 8da6071 + f8d6301 commit 45c80a1
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Feature
* Built with Firefox [WebExtensions](https://developer.mozilla.org/en-US/Add-ons/WebExtensions)
* Add/Update/Delete bookmark from the popup window.
* Icon changing to show current page has been saved or not.
* Keyboard shortcut Alt+P to open popup window

Install
-------
Expand Down
2 changes: 1 addition & 1 deletion js/background.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ var getUserInfo = function () {
// for popup.html to acquire page info
// if there is no page info at local then get it from server
var getPageInfo = function (url) {
if (!url || (url.indexOf('https://') !== 0 && url.indexOf('http://') !== 0) || localStorage[nopingKey] === 'true') {
if (!url || (url.indexOf('https://') !== 0 && url.indexOf('http://') !== 0)) {
return { url: url, isSaved: false };
}
var pageInfo = pages[url];
Expand Down
7 changes: 7 additions & 0 deletions manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,12 @@
"options_ui": {
"page": "html/options.html",
"open_in_tab": true
},
"commands": {
"_execute_browser_action": {
"suggested_key": {
"default": "Alt+P"
}
}
}
}

0 comments on commit 45c80a1

Please sign in to comment.