Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize computeMagneticTarget function definition to prevent unecessary re-definitions with React's useEffect hook #2

Open
loucadufault opened this issue Sep 14, 2021 · 0 comments
Open

Optimize computeMagneticTarget function definition to prevent unecessary re-definitions with React's useEffect hook #2

loucadufault opened this issue Sep 14, 2021 · 0 comments
Labels
internal optimization

Comments

@loucadufault
Copy link
Owner

loucadufault commented Sep 14, 2021 •
edited
Loading

put computeMagneticTarget nested function definition as a callback for React's useEffect hook, so that it is only redefined when one of the dependencies change, that is either of the variables magneticBoundaryDeadzone or magneticRadius change between renders.

This is for optimization reasons only.

see https://github.com/loucadufault/MagneticSlider/blob/main/MagneticSlider.js#L36
@loucadufault loucadufault changed the title Optimize function definition Optimize computeMagneticTarget function definition to prevent unecessary re-definitions Sep 14, 2021
@loucadufault loucadufault changed the title Optimize computeMagneticTarget function definition to prevent unecessary re-definitions Optimize computeMagneticTarget function definition to prevent unecessary re-definitions with React's useEffect hook Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loucadufault