This repository has been archived by the owner on Dec 7, 2020. It is now read-only.
[KEYCLOAK-10265] Support for client credentials grant when in forward-signing mode #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
May 14, 2019
dchrzascik
force-pushed
the
forwarding-grant-type
branch
from
252f045
to
c4d9f7c
Compare
|
It would be great if this could be reviewed/merged 🙂 |
|
Is there a way to get it merged? |
|
Thanks for reaching out and my apologies that this is taking too long. We're currently working on critical bug fixes for the upcoming releases, which does not leave enough room to do a deeper review of it before we can merge, so please bear with us until we have time to review it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keycloak-gatekeeper should support client_credentials grant when in forwarding mode. I have introduced new configuration option: forwarding-grant-type which supports "password" (direct access grant, the current implementation) and "client_credentials" grant.
For details please see: https://issues.jboss.org/browse/KEYCLOAK-10265