Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to display Target Rate entity and support for lowlimit option #39

Merged
merged 9 commits into from
Dec 1, 2023
Merged

Conversation

alfwro13
Copy link
Contributor

@alfwro13 alfwro13 commented Nov 26, 2023

Added support to display target rate entity: https://github.com/BottlecapDave/HomeAssistant-OctopusEnergy/blob/develop/_docs/setup_target_rate.md --> see issue#29

Added support for lowlimit option

Updated documentation and added screenshots to reflect the above changes - tested locally
(this is my first pull request so please let me know if that's not the way to do it)

@alfwro13 alfwro13 changed the title Add support to display Target Rate entity Add support to display Target Rate entity and support for lowlimit option Nov 26, 2023
@alfwro13 alfwro13 changed the title Add support to display Target Rate entity and support for lowlimit option Added support to display Target Rate entity and support for lowlimit option Nov 26, 2023
Copy link
Owner

@lozzd lozzd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great set of additions! Few minor comments about the README, let me know what you think..

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@alfwro13
Copy link
Contributor Author

I have updated\corrected the README.md file as suggested

@lozzd lozzd merged commit 8b4605d into lozzd:main Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants