-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pagination to front-end #775
base: master
Are you sure you want to change the base?
Conversation
* Add pagination buttons at the bottom of the page when the number of items to be displayed is greater than the selected preference. * Add a selector to the side bar for users to select their prefered number of items to be displayed at once per page. * Sorting should be handled by the pagination module whenever it keeps the list of items in memory. * Pagination is hidden (buttons are removed) whenever there is no need for it, or when the user selected to display everything.
The Pagination module introduced some new strings.
A few notes on these patches:
You may notice it hovers above the list of displayed items. |
Is it likely this will be merged sometime soon? We really need this for https://repo.sourcify.dev Kudos to @glubsy 👏 |
I tried checking out these commits and #771 but unfortunately it didn't get any faster To try out I created a directory with 20k folders, similar to our own setting with:
The UI still hangs a long time when entering the parent directory of these 20k directories. Is it the mounting of the directory that is really slow? |
It's been a little while since I worked on this, but the other commit you mentioned simply removes the loading of items from the parent directories. The children directories are loaded just like before. There is no lazy loading here, all the child items are still loaded at once. I don't think it would be possible to implement lazy loading without removing the various sort buttons. You would also lose the ability to get the total number of child items per directory (until you have loaded them all), and the total number of pages would be incremented as you load the next pages. This would also need to be implemented on the back-end side, not just front-end. |
items to be displayed is greater than the selected preference.
number of items to be displayed at once per page.
the list of items in memory.
for it, or when the user selected to display everything.
Closes #283.