Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to restrict gems from Gemfile (deps only) #1086

Closed
wants to merge 1 commit into from

Conversation

tonobo
Copy link

@tonobo tonobo commented Apr 20, 2017

Description

The changes will provide a new option on yard server cli command. It will provide the ability to start a server based on gemfile, like --gemfile. The new option --gemfile-deps will only register direct dependencies which has been specified within gemfile.

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

@coveralls
Copy link

coveralls commented Apr 20, 2017

Coverage Status

Coverage decreased (-0.04%) to 93.477% when pulling 4489ef4 on dopykuh:patch-1 into 9f14dbf on lsegal:master.

@lsegal
Copy link
Owner

lsegal commented Apr 20, 2017

This PR is missing a description / problem statement to understand the context and use case for the change.

Sidenote: it's also missing tests.

@tonobo
Copy link
Author

tonobo commented Apr 20, 2017

Description updated. Did you really require tests for it? 😞

@tonobo
Copy link
Author

tonobo commented Apr 21, 2017

Closed due to #1087

@tonobo tonobo closed this Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants