-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-47951 : Update hsc_micro example steps to reflect upstream changes #146
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Future work: discuss if two is enough tiny test steps. LGTM!
I think we should think a bit about how we want to evolve specficiations before doing this. This would break running on older weeklies. That is fine, but isn't exactly what I think we should be doing longer term. What I want in mind would have been more like:
|
[0] Villarreal, Sierra reacted to your message:
…________________________________
From: Eric Charles ***@***.***>
Sent: Wednesday, December 4, 2024 7:56:37 PM
To: lsst-dm/cm-service ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [lsst-dm/cm-service] DM-47951 : Update hsc_micro example steps to reflect upstream changes (PR #146)
BEWARE: This email originated outside of our organization. DO NOT CLICK links or attachments unless you recognize the sender and know the content is safe.
I think we should think a bit about how we want to evolve specficiations before doing this.
This would break running on older weeklies. That is fine, but isn't exactly what I think we should be doing longer term.
What I want in mind would have been more like:
1. Add a step SpecBlock for the new calibrateImage step.
2. Add new SpecBlock and Specifications for hsc_micro_campaign_v1, hsc_micro_panda_v1 and hsc_micro_htcondor_v1 that use the new versions of the Step.
3. update start_hsc_micro.yaml to use the new Specifiations.
—
Reply to this email directly, view it on GitHub<#146 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB4T2SIFHCVAPPNTH57OZGD2D5M7LAVCNFSM6AAAAABTA5JOBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJYGQZTMOJWGE>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
[heart] Villarreal, Sierra reacted to your message:
…________________________________
From: Eric Charles ***@***.***>
Sent: Wednesday, December 4, 2024 7:56:37 PM
To: lsst-dm/cm-service ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [lsst-dm/cm-service] DM-47951 : Update hsc_micro example steps to reflect upstream changes (PR #146)
BEWARE: This email originated outside of our organization. DO NOT CLICK links or attachments unless you recognize the sender and know the content is safe.
I think we should think a bit about how we want to evolve specficiations before doing this.
This would break running on older weeklies. That is fine, but isn't exactly what I think we should be doing longer term.
What I want in mind would have been more like:
1. Add a step SpecBlock for the new calibrateImage step.
2. Add new SpecBlock and Specifications for hsc_micro_campaign_v1, hsc_micro_panda_v1 and hsc_micro_htcondor_v1 that use the new versions of the Step.
3. update start_hsc_micro.yaml to use the new Specifiations.
—
Reply to this email directly, view it on GitHub<#146 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB4T2SIFHCVAPPNTH57OZGD2D5M7LAVCNFSM6AAAAABTA5JOBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJYGQZTMOJWGE>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Replace
characterizeImage
+calibrate
steps with singlecalibrateImage
step as implemented in upstream HSC-RC2 pipeline.