Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47951 : Update hsc_micro example steps to reflect upstream changes #146

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tcjennings
Copy link
Contributor

Replace characterizeImage+calibrate steps with single calibrateImage step as implemented in upstream HSC-RC2 pipeline.

@eigerx eigerx self-requested a review December 4, 2024 19:46
Copy link
Contributor

@eigerx eigerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Future work: discuss if two is enough tiny test steps. LGTM!

@eacharles
Copy link
Collaborator

I think we should think a bit about how we want to evolve specficiations before doing this.

This would break running on older weeklies. That is fine, but isn't exactly what I think we should be doing longer term.

What I want in mind would have been more like:

  1. Add a step SpecBlock for the new calibrateImage step.
  2. Add new SpecBlock and Specifications for hsc_micro_campaign_v1, hsc_micro_panda_v1 and hsc_micro_htcondor_v1 that use the new versions of the Step.
  3. update start_hsc_micro.yaml to use the new Specifiations.

@villarrealas
Copy link
Contributor

villarrealas commented Dec 4, 2024 via email

@villarrealas
Copy link
Contributor

villarrealas commented Dec 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants