Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-48080 : Refactor Config Module #150

Merged
merged 1 commit into from
Dec 19, 2024
Merged

DM-48080 : Refactor Config Module #150

merged 1 commit into from
Dec 19, 2024

Conversation

tcjennings
Copy link
Contributor

  • Use nested models for configs
  • Promote hardcoded values to config variables

@tcjennings tcjennings force-pushed the tickets/DM-48080 branch 7 times, most recently from 1d027fc to 6a20e4f Compare December 17, 2024 19:45
@tcjennings
feat(config): Refactor config module
899a47e 
- Use nested models for configs
- Promote hardcoded values to config variables

chore: Rename all CM_SERVICE_x env vars to DB__x for consistency
eigerx
eigerx approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@eigerx eigerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enables mapping env vars to all of the configs! Nice. Future work: look into validation aliases for nested models.

@tcjennings tcjennings merged commit 4eeddde into main Dec 19, 2024
9 checks passed
@tcjennings tcjennings deleted the tickets/DM-48080 branch December 19, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eigerx eigerx eigerx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcjennings @eigerx