Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-38032: CM tools v2 client infrastructure #5

Merged
merged 3 commits into from
Oct 17, 2023
Merged

DM-38032: CM tools v2 client infrastructure #5

merged 3 commits into from
Oct 17, 2023

Conversation

fritzm
Copy link
Member

@fritzm fritzm commented Oct 17, 2023

  • Update dependencies, particularly to a working set of newer safir/sqlachemy/pydandic/mypy.
  • Move to user-specific container names and dynamic port assignments in docker compose; allows multiple users to debug/test on one machine without collisions.
  • Add very basic client class and extend CLI tool to use it.

fritzm added 3 commits October 17, 2023 08:02
@fritzm
Update dependencies (and related small fixes)
2eca04e 
This brings in a new version of safir, which does now longer
supports Python 3.10 (removed from CI build matrix), and no
longer requires schema init workaround (removed from code).

Small required adjustment to RedisDSN pydantic class init.

Added pydantic.mypy mypy plugin.
@fritzm
Docker compose enhancements
e03f5d5 
These affect test and debug environments only (the only use of
docker compose in this project)

Use dynamic port assignments, to avoid collisions if multiple
devs are sharing a single machine.

Add simple fixed password to redis and postgres (passwordless
servers were triggering SLAC security scan alerts)
@fritzm
Add client class and extend CLI
9b5b987
eacharles
eacharles approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@eacharles eacharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only question is why we are including the dev.txt and main.txt in the github repo

@fritzm
Copy link
Member Author

fritzm commented Oct 17, 2023 •
edited
Loading

Looks good, only question is why we are including the dev.txt and main.txt in the github repo

The intent is to make sure the repo always has a fully elaborated set of dependencies that is tested by CI and guaranteed to work. The checked in set is where you start when you say make init in a fresh venv; it doesn't get modified/updated until/unless you do a make update.

@eacharles eacharles merged commit 21b135c into main Oct 17, 2023
7 checks passed
@eacharles eacharles deleted the tickets/DM-38032 branch October 17, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eacharles eacharles eacharles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzm @eacharles