DM-39022: Add group name presence server. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
force-pushed
the
tickets/DM-39022
branch
5 times, most recently
from
c4fe31c to
0e8ac06
Compare
hsinfang
approved these changes
May 28, 2024
| logger.info("Ingesting %s", resources) | ||
| refs = None | ||
| try: | ||
| refs = ingester.run(resources) | ||
| except Exception: | ||
| logger.exception("Error while ingesting %s", resources) | ||
| continue |
There was a problem hiding this comment.
Why is this needed with this commit?
There was a problem hiding this comment.
This is actually a separate fix that prevents visit definition (and Rucio registration) from trying to run if an exception occurred in ingest. I'll split it out into a separate commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change records the group names/ids of images as they're being ingested and adds a Web service that reports the presence or absence of a particular group name (with instrument, snap, and detector).