Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ingest LSSTCam photodiode data" #61

Merged
merged 1 commit into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/info.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,9 @@ def __init__(self, path):
self.instrument = f"{csc}/{generator}"
elif len(components) == 6:
self.bucket, self.instrument, year, month, day, self.filename = components
elif len(components) == 5: # photodiode data
self.bucket, self.instrument, data_type, self.obs_day, self.filename = components
else:
raise ValueError(f"Unrecognized number of components: {len(components)}")
if not self.obs_day:
self.obs_day = f"{year}{month}{day}"
self.obs_day = f"{year}{month}{day}"
except Exception:
logger.exception("Unable to parse: %s", path)
raise
41 changes: 1 addition & 40 deletions src/ingest.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,13 @@
"""
import json
import os
import re
import socket
import time

import astropy.io.fits
import requests
from lsst.daf.butler import Butler
from lsst.pipe.base import Instrument
from lsst.obs.base import DefineVisitsTask, RawIngestTask
from lsst.obs.lsst import PhotodiodeIngestTask
from lsst.resources import ResourcePath

from info import Info
Expand Down Expand Up @@ -203,18 +200,7 @@ def main():
on_metadata_failure=on_metadata_failure,
)

if is_lfa:
# LSSTCam photodiode is copy mode only.
instrument = Instrument.from_string("LSSTCam", butler.registry)
lsstcam_photodiode_ingester = PhotodiodeIngestTask(
config=PhotodiodeIngestTask.ConfigClass(),
butler=butler,
instrument=instrument,
on_success=on_success,
on_ingest_failure=on_ingest_failure,
on_metadata_failure=on_metadata_failure,
)
else:
if not is_lfa:
define_visits_config = DefineVisitsTask.ConfigClass()
define_visits_config.groupExposures = "one-to-one"
visit_definer = DefineVisitsTask(config=define_visits_config, butler=butler)
Expand All @@ -234,15 +220,6 @@ def main():

logger.info("Ingesting %s", resources)
refs = None
if is_lfa:
resources_photodiode = []
resources_others = []
for resource in resources:
if re.search(r"MTCamera/photodiode.*_photodiode.ecsv", resource):
resources_photodiode.append(resource)
else:
resources_others.append(resource)
resources = resources_others
try:
refs = ingester.run(resources)
except Exception:
Expand All @@ -256,22 +233,6 @@ def main():
info = Info.from_path(resource.geturl())
r.lrem(worker_queue, 0, info.path)

if is_lfa and resources_photodiode:
try:
refs = lsstcam_photodiode_ingester.run(resources_photodiode)
except Exception:
logger.exception(
"Error while ingesting %s, retrying one by one", resources_photodiode
)
refs = []
for resource in resources_photodiode:
try:
refs.extend(lsstcam_photodiode_ingester.run([resource]))
except Exception:
logger.exception("Error while ingesting %s", resource)
info = Info.from_path(resource.geturl())
r.lrem(worker_queue, 0, info.path)

# Define visits if we ingested anything
if not is_lfa and refs:
ids = [ref.dataId for ref in refs]
Expand Down
Loading