Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42677: Don't forward visits with instrument="" #9

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

kfindeisen
Copy link
Member

This PR adds a filter to avoid fanning out nextVisit messages with an empty instrument, as such messages are unprocessable and result in errors in Prompt Processing.

Such messages are created by summit scripts that don't take
observations (e.g., a standalone telescope slew command), and they
confuse Prompt Processing (which assumes that having the wrong
instrument is a serious error).
Copy link
Collaborator

@dspeck1 dspeck1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. To cut a release we need to create a release then add a git tag with the release number. Should we add instructions here or is their another location to put that to avoid re-creating the same instructions (same as for prompt_processing) repo?

@kfindeisen
Copy link
Member Author

Sorry, I don't understand. GitHub releases need an existing tag, and IIRC the web UI will define one if you didn't provide it yourself. How can you create a release and then add a tag? At best, that would mean redefining the tag after the fact.

As for where, the most natural place would be the Playbook in prompt_processing, which already contains instructions for the (old) build process. I see you already added it on lsst-dm/prompt_processing#115, so perhaps we can discuss the details there.

@dspeck1
Copy link
Collaborator

dspeck1 commented Jan 26, 2024

To create a tag type the tag name in the Choose a tag field. Thanks. Sound fine to use prompt_processing playbook. I'll add note that it applies to both repos.

@kfindeisen kfindeisen merged commit da2e9fd into main Jan 26, 2024
2 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-42677 branch January 26, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants