Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40567: Diagnose group mappings to strings #838

Merged
merged 2 commits into from
Aug 30, 2023
Merged

DM-40567: Diagnose group mappings to strings #838

merged 2 commits into from
Aug 30, 2023

Commits on Aug 30, 2023

  1. Diagnose group mappings to strings 

    Gafaelfawr previously accepted a `group_mapping` rule whose value
was a string rather than a list of group names and interpreted it
as a list of single-letter group names corresponding to the letters
in the string. This configuration now produces a validation error
during startup.

Do this by using proper Pydantic models to validate the value of
group_mapping in the settings class and convert to strings only
when building the config. This avoids a complex pre-validator that
was buggy.
    @rra
    rra committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    258220d View commit details
    Browse the repository at this point in the history

  2. Update Python dependencies

    @rra
    rra committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    db65239 View commit details
    Browse the repository at this point in the history