DM-42677: Don't forward visits with instrument="" #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dspeck1
reviewed
Jan 26, 2024
|
Yes, clearly -- we can't create such a release until after lsst-dm/next_visit_fan_out#9 merges if we want it to contain those changes. Do you have any objections to this PR being merged as-is once the 1.0.4 release does exist? It would be inappropriate to merge next_visit_fan_out#9 -- the main portion of this ticket -- while the ticket is still in review. |
This release reverts the changes introduced in 1.0.3, and fixes a bug that spammed Prompt Processing with messages with empty instrument fields.
kfindeisen
force-pushed
the
tickets/DM-42677
branch
from
c7b105f to
ce5d4e2
Compare
|
That's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
next-visit-fan-outwith bug fixes ahead of the January 29 -- February 2 AuxTel run.