Skip to content

Commit

Permalink
Upgrade to uws-server-1.2.21 & modify JobManager to use env IM
Browse files Browse the repository at this point in the history
  • Loading branch information
stvoutsin committed Jul 26, 2024
1 parent cff9606 commit 6a2d108
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 240 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ Find changes for the upcoming release in the project's [changelog.d](https://git

### Fixed

- Introduce RubinIdentityManagerImpl, extends IdentityManager which replaces the deprecated Authenticator
- Changed QueryJobManager to use the IdentityManager available via the AuthenticationUtil class (OpenID in our case)
- Added deprecated AuthenticatorImpl, this is only useful in case this version of TAP is used with the old Auth params/implementations (Unlikely)
- Upgrade version of uws-server to 1.2.21

<a id='changelog-1.18.4'></a>
## 1.18.4 (2024-07-19)
Expand Down
2 changes: 1 addition & 1 deletion tap/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ dependencies {
implementation 'org.opencadc:cadc-tap-server-pg:[1.0.0,)'
implementation 'org.opencadc:cadc-util:1.11.2'
implementation 'org.opencadc:cadc-uws:1.0.5'
implementation 'org.opencadc:cadc-uws-server:1.2.20'
implementation 'org.opencadc:cadc-uws-server:1.2.21'
implementation 'org.opencadc:cadc-vosi:1.4.6'

// Switch out this to use any supported database instead of PostgreSQL.
Expand Down
8 changes: 7 additions & 1 deletion tap/src/main/java/ca/nrc/cadc/sample/JobManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
import ca.nrc.cadc.uws.server.impl.PostgresJobPersistence;
import ca.nrc.cadc.uws.server.SimpleJobManager;
import ca.nrc.cadc.uws.server.ThreadPoolExecutor;
import ca.nrc.cadc.auth.AuthenticationUtil;
import ca.nrc.cadc.auth.IdentityManager;
import ca.nrc.cadc.uws.server.JobPersistence;
import ca.nrc.cadc.uws.server.RandomStringGenerator;


/**
Expand All @@ -21,7 +25,9 @@ public class JobManager extends SimpleJobManager {
public JobManager() {
super();

PostgresJobPersistence jobPersist = new PostgresJobPersistence(new X500IdentityManager());
IdentityManager im = AuthenticationUtil.getIdentityManager();
// persist UWS jobs to PostgreSQL using default jdbc/uws connection pool
JobPersistence jobPersist = new PostgresJobPersistence(new RandomStringGenerator(16), im, true);

// max threads: 6 == number of simultaneously running async queries (per
// web server), plus sync queries, plus VOSI-tables queries
Expand Down
237 changes: 0 additions & 237 deletions tap/src/main/java/ca/nrc/cadc/sample/RubinIdentityManagerImpl.java

This file was deleted.

0 comments on commit 6a2d108

Please sign in to comment.