[DM-41951] set auto commit to false #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbanek
force-pushed
the
tickets/DM-41951
branch
2 times, most recently
from
c76b539
to
2f0692e
Compare
This might be holding open a transaction on the connection, making memory go out of control. The default here is true.
cbanek
force-pushed
the
tickets/DM-41951
branch
from
2f0692e
to
6d35ec5
Compare
cbanek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mimics a change in lsst-tap-service to keep the memory usage small. Setting the auto commit to false should get the jdbc driver to use the cursor mode when reading back results. Without this it seems that the results of a query are currently fully read into memory before being returned.