Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/sitcom 1444 #124

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Tickets/sitcom 1444 #124

merged 1 commit into from
Aug 29, 2024

Conversation

Kelks19
Copy link
Contributor

@Kelks19 Kelks19 commented Aug 5, 2024

I have migrated the procedure to Obs-Ops. I have also corrected a bit of English and the flow while keeping teh content exactly same.
There is several important things I identified as missing from the content ---

  1. Please note that there are two figures missing-- I think we need to create a follow-up ticket to add them once we get access to OSS activity from the TMA EUI
  2. We need to highlight again how to access to TMA EUI and include link to the relevant page
  3. The confluence page says that Safety Team should be included as authors. Can you specifiy which ones ?

I was not involved in the content creation and the review of the original Confluence page.

Copy link
Contributor

@isotuela isotuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks good. I have added some suggestions, mostly regarding the caption in figures and the position of the LOTO box note. I think if each step's key words is in bold, it would improve reading, just like in step 2 of Applying LOTO on OSS.
Also, please squash commits into a single one. Let me know if you need any help!
Thank you!

@Kelks19 Kelks19 requested a review from isotuela August 16, 2024 19:29
@Kelks19 Kelks19 force-pushed the tickets/SITCOM-1444 branch 2 times, most recently from 25a9fe0 to 727c18c Compare August 17, 2024 00:45
@isotuela isotuela force-pushed the tickets/SITCOM-1444 branch 2 times, most recently from 247e7de to 73b1e0d Compare August 17, 2024 00:57
@isotuela isotuela force-pushed the tickets/SITCOM-1444 branch 2 times, most recently from 3f63376 to c33cb18 Compare August 17, 2024 01:16
Copy link
Contributor

@Slimleashma Slimleashma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the new photos and explicit instructions about the LOTO boxes. One note to make (and maybe there is hesitance to make this official) is that during the night, only ONE pump needs to be locked to consider the TMA fully under LOTO. This is helpful when one cannot find the LOTO boxes or there aren't multiple people around to move this process faster. It's something to note that LOTO at night with multiple locks and keys raises a risk of leaving lights on longer and losing these multiples. Can we consider this additional caveat for the document?

@Kelks19
Copy link
Contributor Author

Kelks19 commented Aug 19, 2024

@Slimleashma I can add a note box with 'LOTO at night ' to highlight these caveats -- What do you think ?
This note can be convereted to sub-section after we confirm the official word on it.

@Slimleashma
Copy link
Contributor

Slimleashma commented Aug 19, 2024 via email

@Kelks19
Copy link
Contributor Author

Kelks19 commented Aug 27, 2024

@Slimleashma @isotuela- I added a note about "LOTO at night". Could you please check if it reads ok?

Copy link
Contributor

@isotuela isotuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor grammar comment. Could you please squash your commits into one? Let me know if you encounter any issue.

Thanks!
Ioana

Copy link
Contributor

@Slimleashma Slimleashma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the nighttime caveat.

@Kelks19
Copy link
Contributor Author

Kelks19 commented Aug 27, 2024

@isotuela formatting corrected and commits squashed!

@isotuela isotuela force-pushed the tickets/SITCOM-1444 branch 2 times, most recently from ad3037d to d1569c3 Compare August 29, 2024 13:26
Copy link
Contributor

@isotuela isotuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good and ready to merge.
Thanks!

@Kelks19 Kelks19 merged commit a3e5e6c into main Aug 29, 2024
2 checks passed
@Kelks19 Kelks19 deleted the tickets/SITCOM-1444 branch August 29, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants