-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tickets/sitcom 1639 #141
Tickets/sitcom 1639 #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this structure, thank you!
I added 3 comments.
A fourth comment is that for both AuxTel and Simonyi “Calibration system” page is repeated, there is one under components and another under troubleshooting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was under Non-standard procedures before, I think it’s better suited in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“AuxTel E-stop procedure” is repeated and there is “<<<<<<< HEAD” before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Not sure what happened in the rebase there.
@@ -41,8 +41,7 @@ Introduction to the Simonyi Telescope | |||
|
|||
Components/MTCS/index.rst | |||
Components/* | |||
Components/Auxiliary-Components/index.rst | |||
|
|||
|
|||
.. _Simonyi-Telescope-Weather-Constraints: | |||
|
|||
Weather Constraints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 links that take to the same page "Simonyi Weather Constraints"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I have add the option :hidden:
to the toctree
so it shows in the left hand side menu, but not in the page itself.
@JackieS-NL Thank you for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ioana
068c5d4
to
b9029d0
Compare
Many thanks, @JackieS-NL! |
Sorry for the late reaction. I just compared the obs-doc versions and the changes definitely go in the right direction. Thank you both, @isotuela and @JackieS-NL . |
This is a minor restructuring of Simonyi, AuxTel and Observatory Control System folders to reflect more the OBS division System/Subsystem. (although there's a lot of moved files) I have also taken advantage to add some of the information required in SITCOM-1703. More details and links will be added in the near future.
Thank you for your review.
Ioana