Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/sitcom 1639 #141

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Tickets/sitcom 1639 #141

merged 1 commit into from
Nov 5, 2024

Conversation

isotuela
Copy link
Contributor

This is a minor restructuring of Simonyi, AuxTel and Observatory Control System folders to reflect more the OBS division System/Subsystem. (although there's a lot of moved files) I have also taken advantage to add some of the information required in SITCOM-1703. More details and links will be added in the near future.

Thank you for your review.
Ioana

Copy link
Contributor

@JackieS-NL JackieS-NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this structure, thank you!
I added 3 comments.
A fourth comment is that for both AuxTel and Simonyi “Calibration system” page is repeated, there is one under components and another under troubleshooting.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was under Non-standard procedures before, I think it’s better suited in there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“AuxTel E-stop procedure” is repeated and there is “<<<<<<< HEAD” before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure what happened in the rebase there.

@@ -41,8 +41,7 @@ Introduction to the Simonyi Telescope

Components/MTCS/index.rst
Components/*
Components/Auxiliary-Components/index.rst


.. _Simonyi-Telescope-Weather-Constraints:

Weather Constraints
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 links that take to the same page "Simonyi Weather Constraints"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I have add the option :hidden: to the toctree so it shows in the left hand side menu, but not in the page itself.

@isotuela
Copy link
Contributor Author

isotuela commented Nov 3, 2024

@JackieS-NL Thank you for your review!
Re your fourth comment, I have decided to keep the same name of the pages for now because they belong to different sections. The menus would look too heavy (in my opinion) with all the "ATCalSys Troubleshooting", "ATCS Non Standard Operations". I am still looking for a better way, but will leave it as it is until we find a better solution.
Cheers,
Ioana

Copy link
Contributor

@JackieS-NL JackieS-NL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ioana

@isotuela
Copy link
Contributor Author

isotuela commented Nov 5, 2024

Many thanks, @JackieS-NL!

@isotuela isotuela merged commit 8fceaeb into main Nov 5, 2024
2 checks passed
@isotuela isotuela deleted the tickets/SITCOM-1639 branch November 5, 2024 01:49
@kpenaramirez
Copy link
Contributor

Sorry for the late reaction. I just compared the obs-doc versions and the changes definitely go in the right direction. Thank you both, @isotuela and @JackieS-NL .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants